ember/continuwuity
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(spaces): remove is_enabled_for_space guard from ensure_default_roles
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 5s
Details
Update flake hashes / update-flake-hashes (pull_request) Failing after 5s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Failing after 4s
Details

Browse source 
The guard prevented ensure_default_roles from working in the enable
command — it checked the cascading state event which hasn't been
written yet at that point. Callers should gate this themselves.
This commit is contained in:
ember33 2026-03-19 19:55:44 +01:00
parent 5787f38906
commit 4df2fe2923
1 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/service/rooms/roles/mod.rs
View file

@ -208,10 +208,6 @@ pub async fn is_enabled_for_space(&self, space_id: &RoomId) -> bool {
#[implement(Service)] #[implement(Service)]
pub async fn ensure_default_roles(&self, space_id: &RoomId) -> Result { pub async fn ensure_default_roles(&self, space_id: &RoomId) -> Result {
if !self.is_enabled_for_space(space_id).await {
return Ok(());
}
let server_user = self.services.globals.server_user.as_ref(); let server_user = self.services.globals.server_user.as_ref();
let state_lock = self.services.state.mutex.lock(space_id).await; let state_lock = self.services.state.mutex.lock(space_id).await;