From 4df2fe29235b68034bf6f9651b23ecdc0693b13e Mon Sep 17 00:00:00 2001
From: ember33 <embergayshark@pm.me>
Date: Thu, 19 Mar 2026 19:55:44 +0100
Subject: [PATCH] fix(spaces): remove is_enabled_for_space guard from
 ensure_default_roles
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The guard prevented ensure_default_roles from working in the enable
command — it checked the cascading state event which hasn't been
written yet at that point. Callers should gate this themselves.
---
 src/service/rooms/roles/mod.rs | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/service/rooms/roles/mod.rs b/src/service/rooms/roles/mod.rs
index b634d1bc..4a28bcb4 100644
--- a/src/service/rooms/roles/mod.rs
+++ b/src/service/rooms/roles/mod.rs
@@ -208,10 +208,6 @@ pub async fn is_enabled_for_space(&self, space_id: &RoomId) -> bool {
 
 #[implement(Service)]
 pub async fn ensure_default_roles(&self, space_id: &RoomId) -> Result {
-	if !self.is_enabled_for_space(space_id).await {
-		return Ok(());
-	}
-
 	let server_user = self.services.globals.server_user.as_ref();
 	let state_lock = self.services.state.mutex.lock(space_id).await;