ember/fluffychat
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: HTML renderer edge-case without top-level element

Browse source 
Signed-off-by: The one with the braid <info@braid.business>
This commit is contained in:
The one with the braid 2024-01-13 14:07:00 +01:00
parent e6bbb8f980
commit defe39bc88
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/pages/chat/events/html_message.dart
View file

@ -88,7 +88,13 @@ class HtmlMessage extends StatelessWidget {
padding: HtmlPaddings.only(left: 6, bottom: 0),
);
final element = _linkifyHtml(HtmlParser.parseHTML(renderHtml));
// I encountered messages containing only a String with several HTML elements - without a common parent containing
// them - in this case, we'd end up with *several* top level elements - and the HTML parser fails
//
// We hence add an inline-block `<div>` around the entire message in order to ensure we're dealing with a single
// top-level element.
final paddedHtml = '<div style="display: inline-block;">$renderHtml</div>';
final element = _linkifyHtml(HtmlParser.parseHTML(paddedHtml));
// there is no need to pre-validate the html, as we validate it while rendering
return Html.fromElement(