From 3e4bbc4b2f68bc4277c4d4c9c23f049aefb0c434 Mon Sep 17 00:00:00 2001 From: Marcus Hoffmann Date: Sun, 11 Feb 2024 13:58:37 +0100 Subject: [PATCH 1/2] fix: use correct icons for mark read/unread action If any selected room is not marked unread (anySelectedRoomNotMarkedUnread), then show the 'mark unread' action icon, else show the 'mark as read' icon. This makes it consistent with the notification on/off action. --- lib/pages/chat_list/chat_list_header.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/pages/chat_list/chat_list_header.dart b/lib/pages/chat_list/chat_list_header.dart index d7af38e94..0aa5a4415 100644 --- a/lib/pages/chat_list/chat_list_header.dart +++ b/lib/pages/chat_list/chat_list_header.dart @@ -138,8 +138,8 @@ class ChatListHeader extends StatelessWidget implements PreferredSizeWidget { tooltip: L10n.of(context)!.toggleUnread, icon: Icon( controller.anySelectedRoomNotMarkedUnread - ? Icons.mark_chat_read_outlined - : Icons.mark_chat_unread_outlined, + ? Icons.mark_chat_unread_outlined + : Icons.mark_chat_read_outlined, ), onPressed: controller.toggleUnread, ), From bc68a4faaa9e85b21692256ebfb8c31702ce4009 Mon Sep 17 00:00:00 2001 From: Marcus Hoffmann Date: Sun, 11 Feb 2024 14:08:45 +0100 Subject: [PATCH 2/2] fix: use correct icons for chat pin/unpin Similarly to the read/unread toggle this was also using the wrong icon. If any selected room is not favourite, then show the pin icon (which should represent the "mark as favourite" action as it corresponds to the filled pin shown next to a favourited room. Otherwise show the outline icon, representing the "unpin" action. --- lib/pages/chat_list/chat_list_header.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/pages/chat_list/chat_list_header.dart b/lib/pages/chat_list/chat_list_header.dart index 0aa5a4415..3cf2bde79 100644 --- a/lib/pages/chat_list/chat_list_header.dart +++ b/lib/pages/chat_list/chat_list_header.dart @@ -147,8 +147,8 @@ class ChatListHeader extends StatelessWidget implements PreferredSizeWidget { tooltip: L10n.of(context)!.toggleFavorite, icon: Icon( controller.anySelectedRoomNotFavorite - ? Icons.push_pin_outlined - : Icons.push_pin, + ? Icons.push_pin + : Icons.push_pin_outlined, ), onPressed: controller.toggleFavouriteRoom, ),