From c4d9a2d2b32056e2b530b334aad95e67e60c6f75 Mon Sep 17 00:00:00 2001 From: ggurdin <46800240+ggurdin@users.noreply.github.com> Date: Tue, 24 Feb 2026 16:46:50 -0500 Subject: [PATCH] fix: don't hide emoji match for constructs with assigned emojis (#5807) --- .../message_practice/practice_controller.dart | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/lib/pangea/toolbar/message_practice/practice_controller.dart b/lib/pangea/toolbar/message_practice/practice_controller.dart index 126541be9..d0f08aef9 100644 --- a/lib/pangea/toolbar/message_practice/practice_controller.dart +++ b/lib/pangea/toolbar/message_practice/practice_controller.dart @@ -106,16 +106,18 @@ class PracticeController with ChangeNotifier { bool isPracticeButtonEmpty(PangeaToken token) { final target = practiceTargetForToken(token); - return switch (_practiceMode) { + switch (_practiceMode) { // Keep open when completed if emoji assigned - MessagePracticeMode.wordEmoji => - target == null || token.vocabConstructID.userSetEmoji != null, + case MessagePracticeMode.wordEmoji: + if (token.vocabConstructID.userSetEmoji != null) return false; + return target == null; // Keep open when completed to show morph icon - MessagePracticeMode.wordMorph => target == null, - _ => - target == null || - PracticeRecordController.isCompleteByToken(target, token), - }; + case MessagePracticeMode.wordMorph: + return target == null; + default: + return target == null || + PracticeRecordController.isCompleteByToken(target, token); + } } PracticeTarget? practiceTargetForToken(PangeaToken token) {