From 49780b01fe757119c9e99d6e281367a51673ea41 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christian=20Ku=C3=9Fowski?= <c.kussowski@famedly.com>
Date: Thu, 29 May 2025 12:44:06 +0200
Subject: [PATCH] fix: App crash on page navigation with open popup menu

---
 lib/pages/chat/chat_input_row.dart                      | 3 +++
 lib/pages/chat/chat_view.dart                           | 1 +
 lib/pages/chat_list/client_chooser_button.dart          | 1 +
 lib/pages/chat_list/space_view.dart                     | 1 +
 lib/pages/homeserver_picker/homeserver_picker_view.dart | 1 +
 lib/pages/settings_emotes/settings_emotes_view.dart     | 1 +
 lib/widgets/chat_settings_popup_menu.dart               | 1 +
 lib/widgets/log_view.dart                               | 1 +
 8 files changed, 10 insertions(+)

diff --git a/lib/pages/chat/chat_input_row.dart b/lib/pages/chat/chat_input_row.dart
index 6f90a292c..f5464f27c 100644
--- a/lib/pages/chat/chat_input_row.dart
+++ b/lib/pages/chat/chat_input_row.dart
@@ -118,6 +118,7 @@ class ChatInputRow extends StatelessWidget {
                 decoration: const BoxDecoration(),
                 clipBehavior: Clip.hardEdge,
                 child: PopupMenuButton<String>(
+                  useRootNavigator: true,
                   icon: const Icon(Icons.add_circle_outline),
                   iconColor: theme.colorScheme.onPrimaryContainer,
                   onSelected: controller.onAddPopupMenuButtonSelected,
@@ -198,6 +199,7 @@ class ChatInputRow extends StatelessWidget {
                   decoration: const BoxDecoration(),
                   clipBehavior: Clip.hardEdge,
                   child: PopupMenuButton(
+                    useRootNavigator: true,
                     icon: const Icon(Icons.camera_alt_outlined),
                     onSelected: controller.onAddPopupMenuButtonSelected,
                     iconColor: theme.colorScheme.onPrimaryContainer,
@@ -365,6 +367,7 @@ class _ChatAccountPicker extends StatelessWidget {
       child: FutureBuilder<Profile>(
         future: controller.sendingClient.fetchOwnProfile(),
         builder: (context, snapshot) => PopupMenuButton<String>(
+          useRootNavigator: true,
           onSelected: (mxid) => _popupMenuButtonSelected(mxid, context),
           itemBuilder: (BuildContext context) => clients
               .map(
diff --git a/lib/pages/chat/chat_view.dart b/lib/pages/chat/chat_view.dart
index d4ad88205..beee6fc3f 100644
--- a/lib/pages/chat/chat_view.dart
+++ b/lib/pages/chat/chat_view.dart
@@ -72,6 +72,7 @@ class ChatView extends StatelessWidget {
           ),
         if (controller.selectedEvents.length == 1)
           PopupMenuButton<_EventContextAction>(
+            useRootNavigator: true,
             onSelected: (action) {
               switch (action) {
                 case _EventContextAction.info:
diff --git a/lib/pages/chat_list/client_chooser_button.dart b/lib/pages/chat_list/client_chooser_button.dart
index a9b13e731..6e566366a 100644
--- a/lib/pages/chat_list/client_chooser_button.dart
+++ b/lib/pages/chat_list/client_chooser_button.dart
@@ -162,6 +162,7 @@ class ClientChooserButton extends StatelessWidget {
         borderRadius: BorderRadius.circular(99),
         color: Colors.transparent,
         child: PopupMenuButton<Object>(
+          useRootNavigator: true,
           popUpAnimationStyle: FluffyThemes.isColumnMode(context)
               ? AnimationStyle.noAnimation
               : null, // https://github.com/flutter/flutter/issues/167180
diff --git a/lib/pages/chat_list/space_view.dart b/lib/pages/chat_list/space_view.dart
index 695c8bbab..294bad50e 100644
--- a/lib/pages/chat_list/space_view.dart
+++ b/lib/pages/chat_list/space_view.dart
@@ -265,6 +265,7 @@ class _SpaceViewState extends State<SpaceView> {
         ),
         actions: [
           PopupMenuButton<SpaceActions>(
+            useRootNavigator: true,
             onSelected: _onSpaceAction,
             itemBuilder: (context) => [
               PopupMenuItem(
diff --git a/lib/pages/homeserver_picker/homeserver_picker_view.dart b/lib/pages/homeserver_picker/homeserver_picker_view.dart
index d637c0991..c1878b8a4 100644
--- a/lib/pages/homeserver_picker/homeserver_picker_view.dart
+++ b/lib/pages/homeserver_picker/homeserver_picker_view.dart
@@ -35,6 +35,7 @@ class HomeserverPickerView extends StatelessWidget {
         ),
         actions: [
           PopupMenuButton<MoreLoginActions>(
+            useRootNavigator: true,
             onSelected: controller.onMoreAction,
             itemBuilder: (_) => [
               PopupMenuItem(
diff --git a/lib/pages/settings_emotes/settings_emotes_view.dart b/lib/pages/settings_emotes/settings_emotes_view.dart
index ccd3b9e55..3134cba8d 100644
--- a/lib/pages/settings_emotes/settings_emotes_view.dart
+++ b/lib/pages/settings_emotes/settings_emotes_view.dart
@@ -29,6 +29,7 @@ class EmotesSettingsView extends StatelessWidget {
         title: Text(L10n.of(context).customEmojisAndStickers),
         actions: [
           PopupMenuButton<PopupMenuEmojiActions>(
+            useRootNavigator: true,
             onSelected: (value) {
               switch (value) {
                 case PopupMenuEmojiActions.export:
diff --git a/lib/widgets/chat_settings_popup_menu.dart b/lib/widgets/chat_settings_popup_menu.dart
index fb963a805..3978d5e99 100644
--- a/lib/widgets/chat_settings_popup_menu.dart
+++ b/lib/widgets/chat_settings_popup_menu.dart
@@ -52,6 +52,7 @@ class ChatSettingsPopupMenuState extends State<ChatSettingsPopupMenu> {
       children: [
         const SizedBox.shrink(),
         PopupMenuButton<ChatPopupMenuActions>(
+          useRootNavigator: true,
           onSelected: (choice) async {
             switch (choice) {
               case ChatPopupMenuActions.leave:
diff --git a/lib/widgets/log_view.dart b/lib/widgets/log_view.dart
index caeaeee44..0779af6e6 100644
--- a/lib/widgets/log_view.dart
+++ b/lib/widgets/log_view.dart
@@ -36,6 +36,7 @@ class LogViewerState extends State<LogViewer> {
             onPressed: () => setState(() => fontSize--),
           ),
           PopupMenuButton<Level>(
+            useRootNavigator: true,
             itemBuilder: (context) => Level.values
                 .map(
                   (level) => PopupMenuItem(