if version is bigger, don't account for build name (#1237)

This commit is contained in:
ggurdin 2024-12-13 10:35:42 -05:00 committed by GitHub
parent 50b435b7e9
commit a4861cd15f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -71,7 +71,8 @@ class AppVersionController {
final remoteBuildNumberInt = int.parse(remoteBuildNumber);
// indicates if the current version is older than the remote version
bool isOlderVersion = false;
bool isOlderCurrentVersion = false;
bool isDifferentVersion = false;
// Loop through the remote and current version parts
// and compare them. If a part of the current version
@ -84,10 +85,12 @@ class AppVersionController {
i < min(currentVersionParts.length, remoteVersionParts.length);
i++) {
if (currentVersionParts[i] < remoteVersionParts[i]) {
isOlderVersion = true;
isOlderCurrentVersion = true;
isDifferentVersion = true;
break;
} else if (currentVersionParts[i] > remoteVersionParts[i]) {
isOlderVersion = false;
isOlderCurrentVersion = false;
isDifferentVersion = true;
break;
}
}
@ -101,11 +104,11 @@ class AppVersionController {
}
// also compare the build numbers
if (!isOlderVersion && currentBuildNumberInt < remoteBuildNumberInt) {
isOlderVersion = true;
if (!isDifferentVersion && currentBuildNumberInt < remoteBuildNumberInt) {
isOlderCurrentVersion = true;
}
if (!isOlderVersion && !mandatoryUpdate) {
if (!isOlderCurrentVersion && !mandatoryUpdate) {
return;
}