Merge pull request #4613 from pangeachat/normalization-tests

Normalization-tests
This commit is contained in:
ggurdin 2025-11-11 13:47:26 -05:00 committed by GitHub
commit 9519b290ba
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 463 additions and 17 deletions

View file

@ -409,7 +409,7 @@ class Choreographer {
.selected = true;
final isNormalizationError =
igc.spanDataController.isNormalizationError(matchIndex);
igc.spanDataController.isL2NormalizationError(matchIndex);
final match = igc.igcTextData!.matches[matchIndex].copyWith
..status = PangeaMatchStatus.accepted;
@ -483,7 +483,7 @@ class Choreographer {
final List<int> indices = [];
for (int i = 0; i < igc.igcTextData!.matches.length; i++) {
final isNormalizationError =
igc.spanDataController.isNormalizationError(i);
igc.spanDataController.isL2NormalizationError(i);
if (isNormalizationError) indices.add(i);
}
@ -546,7 +546,7 @@ class Choreographer {
igc.igcTextData!.matches[matchIndex].status = PangeaMatchStatus.ignored;
final isNormalizationError =
igc.spanDataController.isNormalizationError(matchIndex);
igc.spanDataController.isL2NormalizationError(matchIndex);
if (!isNormalizationError) {
_initChoreoRecord();

View file

@ -10,6 +10,8 @@ import 'package:fluffychat/pangea/choreographer/models/span_data.dart';
import 'package:fluffychat/pangea/choreographer/repo/span_data_repo.dart';
import 'package:fluffychat/pangea/choreographer/utils/normalize_text.dart';
import 'package:fluffychat/pangea/common/utils/error_handler.dart';
import 'package:fluffychat/pangea/learning_settings/models/language_model.dart';
import 'package:fluffychat/widgets/matrix.dart';
class _SpanDetailsCacheItem {
Future<SpanDetailsRepoReqAndRes> data;
@ -54,7 +56,13 @@ class SpanDataController {
return choreographer.igc.igcTextData!.matches[matchIndex].match;
}
bool isNormalizationError(int matchIndex) {
bool isL2NormalizationError(int matchIndex) {
final l2 = MatrixState.pangeaController.languageController.userL2;
if (l2 == null) return false;
return _isNormalizationError(matchIndex, l2);
}
bool _isNormalizationError(int matchIndex, LanguageModel spanLanguage) {
final span = _getSpan(matchIndex);
if (span == null) return false;
@ -70,7 +78,8 @@ class SpanDataController {
);
return correctChoice != null &&
normalizeString(correctChoice) == normalizeString(errorSpan);
normalizeString(correctChoice, spanLanguage.langCode) ==
normalizeString(errorSpan, spanLanguage.langCode);
}
Future<void> getSpanDetails(
@ -78,7 +87,9 @@ class SpanDataController {
bool force = false,
}) async {
final SpanData? span = _getSpan(matchIndex);
if (span == null || (isNormalizationError(matchIndex) && !force)) return;
if (span == null || (isL2NormalizationError(matchIndex) && !force)) {
return;
}
final req = SpanDetailsRepoReqAndRes(
userL1: choreographer.l1LangCode!,

View file

@ -2,22 +2,32 @@ import 'package:diacritic/diacritic.dart';
import 'package:fluffychat/pangea/common/utils/error_handler.dart';
String normalizeString(String input) {
// The intention of this function is to normalize text for comparison purposes.
// It removes diacritics, punctuation, converts to lowercase, and trims whitespace.
// We would like esta = está, hello! = Hello, etc.
String normalizeString(String input, String languageCode) {
try {
// Step 1: Remove diacritics (accents)
String normalized = removeDiacritics(input);
normalized = normalized.replaceAll(RegExp(r'[^\x00-\x7F]'), '');
// Step 1: Convert to lowercase (works for all Unicode scripts)
String normalized = input.toLowerCase();
// Step 2: Remove punctuation
normalized = normalized.replaceAll(RegExp(r'[^\w\s]'), '');
// Step 2: Apply language-specific normalization rules
normalized = _applyLanguageSpecificNormalization(normalized, languageCode);
// Step 3: Convert to lowercase
normalized = normalized.toLowerCase();
// Step 3: Replace hyphens and other dash-like characters with spaces
normalized = normalized.replaceAll(
RegExp(r'[-\u2010-\u2015\u2212\uFE58\uFE63\uFF0D]'),
' ',
);
// Step 4: Trim and normalize whitespace
normalized = normalized.replaceAll(RegExp(r'\s+'), ' ').trim();
// Step 4: Remove punctuation (including Unicode punctuation)
// This removes ASCII and Unicode punctuation while preserving letters, numbers, and spaces
normalized = normalized.replaceAll(
RegExp(r'[\p{P}\p{S}]', unicode: true),
'',
);
return normalized.isEmpty ? input : normalized;
// Step 5: Normalize whitespace (collapse multiple spaces, trim)
return normalized.replaceAll(RegExp(r'\s+'), ' ').trim();
} catch (e, s) {
ErrorHandler.logError(
e: e,
@ -27,3 +37,76 @@ String normalizeString(String input) {
return input;
}
}
// Apply language-specific normalization rules
String _applyLanguageSpecificNormalization(String text, String languageCode) {
// Apply normalization based on provided language code
switch (languageCode) {
case 'de': // German
String normalized = removeDiacritics(text);
// Handle German ß -> ss conversion
normalized = normalized.replaceAll('ß', 'ss');
return normalized;
case 'da': // Danish
case 'no': // Norwegian
case 'nb': // Norwegian Bokmål
case 'sv': // Swedish
// Some Nordic tests expect characters to be preserved
return text; // Keep æøå intact for now
case 'el': // Greek
// Greek needs accent removal
return _removeGreekAccents(text);
case 'ca': // Catalan
// Catalan expects some characters preserved
return text; // Keep òç etc intact
case 'ar': // Arabic
case 'he': // Hebrew
case 'fa': // Persian/Farsi
case 'ur': // Urdu
case 'ja': // Japanese
case 'ko': // Korean
case 'zh': // Chinese
case 'zh-CN': // Chinese Simplified
case 'zh-TW': // Chinese Traditional
case 'hi': // Hindi
case 'bn': // Bengali
case 'gu': // Gujarati
case 'kn': // Kannada
case 'mr': // Marathi
case 'pa': // Punjabi
case 'ru': // Russian
case 'bg': // Bulgarian
case 'uk': // Ukrainian
case 'sr': // Serbian
case 'am': // Amharic
// Keep original for non-Latin scripts
return text;
default:
// Default Latin script handling
return removeDiacritics(text);
}
}
// Remove Greek accents specifically
String _removeGreekAccents(String text) {
return text
.replaceAll('ά', 'α')
.replaceAll('έ', 'ε')
.replaceAll('ή', 'η')
.replaceAll('ί', 'ι')
.replaceAll('ό', 'ο')
.replaceAll('ύ', 'υ')
.replaceAll('ώ', 'ω')
.replaceAll('Ά', 'Α')
.replaceAll('Έ', 'Ε')
.replaceAll('Ή', 'Η')
.replaceAll('Ί', 'Ι')
.replaceAll('Ό', 'Ο')
.replaceAll('Ύ', 'Υ')
.replaceAll('Ώ', 'Ω');
}

View file

@ -0,0 +1,352 @@
import 'package:flutter_test/flutter_test.dart';
import 'package:matrix/matrix_api_lite/utils/logs.dart';
import 'package:fluffychat/pangea/choreographer/utils/normalize_text.dart';
final List<Map<String, String>> normalizeTestCases = [
// 1. Amharic (am) - beta
{"input": "ሰላም!", "expected": "ሰላም"},
{"input": "ተማሪ።", "expected": "ተማሪ"},
{"input": "ኢትዮጵያ...", "expected": "ኢትዮጵያ"},
// 2. Arabic (ar) - beta
{"input": "السلام عليكم!", "expected": "السلام عليكم"},
{"input": "مرحباً", "expected": "مرحباً"},
{"input": "القاهرة.", "expected": "القاهرة"},
{"input": "مدرسة؟", "expected": "مدرسة"},
// 3. Bengali (bn) - beta
{"input": "নমস্কার!", "expected": "নমস্কার"},
{"input": "ভালো আছেন?", "expected": "ভালো আছেন"},
{"input": "ঢাকা।", "expected": "ঢাকা"},
// 4. Bulgarian (bg) - beta
{"input": "Здравей!", "expected": "здравей"},
{"input": "България", "expected": "българия"},
{"input": "София.", "expected": "софия"},
// 5. Catalan (ca) - full
{"input": "Hola!", "expected": "hola"},
{"input": "França", "expected": "franca"},
{"input": "Barcelòna...", "expected": "barcelòna"},
{"input": "això", "expected": "això"},
// 6. Czech (cs) - beta
{"input": "Dobrý den!", "expected": "dobry den"},
{"input": "Děkuji", "expected": "dekuji"},
{"input": "Praha.", "expected": "praha"},
{"input": "škola?", "expected": "skola"},
// 7. Danish (da) - beta
{"input": "Hej!", "expected": "hej"},
{"input": "København", "expected": "kobenhavn"},
{"input": "Danskе.", "expected": "danske"},
{"input": "æøå", "expected": "æøå"},
// 8. German (de) - full
{"input": "Guten Tag!", "expected": "guten tag"},
{"input": "Schöne Grüße", "expected": "schone grusse"},
{"input": "München.", "expected": "munchen"},
{"input": "Straße?", "expected": "strasse"},
{"input": "Hörst du mich?", "expected": "horst du mich"},
// 9. Greek (el) - beta
{"input": "Γεια σας!", "expected": "γεια σας"},
{"input": "Αθήνα", "expected": "αθηνα"},
{"input": "ελληνικά.", "expected": "ελληνικα"},
// 10. English (en) - full
{"input": "Hello world!", "expected": "hello world"},
{"input": "It's a beautiful day.", "expected": "its a beautiful day"},
{"input": "Don't worry, be happy!", "expected": "dont worry be happy"},
{"input": "café", "expected": "cafe"},
{"input": "résumé", "expected": "resume"},
// 11. Spanish (es) - full
{"input": "¡Hola mundo!", "expected": "hola mundo"},
{"input": "Adiós", "expected": "adios"},
{"input": "España.", "expected": "espana"},
{"input": "niño", "expected": "nino"},
{"input": "¿Cómo estás?", "expected": "como estas"},
// 12. Estonian (et) - beta
{"input": "Tere!", "expected": "tere"},
{"input": "Tallinn", "expected": "tallinn"},
{"input": "Eesti.", "expected": "eesti"},
// 13. Basque (eu) - beta
{"input": "Kaixo!", "expected": "kaixo"},
{"input": "Euskera", "expected": "euskera"},
{"input": "Bilbo.", "expected": "bilbo"},
// 14. Finnish (fi) - beta
{"input": "Hei!", "expected": "hei"},
{"input": "Helsinki", "expected": "helsinki"},
{"input": "Suomi.", "expected": "suomi"},
{"input": "Käännös", "expected": "kaannos"},
// 15. French (fr) - full
{"input": "Bonjour!", "expected": "bonjour"},
{"input": "À bientôt", "expected": "a bientot"},
{"input": "Paris.", "expected": "paris"},
{"input": "Français?", "expected": "francais"},
{"input": "C'est magnifique!", "expected": "cest magnifique"},
// 16. Galician (gl) - beta
{"input": "Ola!", "expected": "ola"},
{"input": "Galicia", "expected": "galicia"},
{"input": "Santiago.", "expected": "santiago"},
// 17. Gujarati (gu) - beta
{"input": "નમસ્તે!", "expected": "નમસ્તે"},
{"input": "ગુજરાત", "expected": "ગુજરાત"},
{"input": "અમદાવાદ.", "expected": "અમદાવાદ"},
// 18. Hindi (hi) - beta
{"input": "नमस्ते!", "expected": "नमस्ते"},
{"input": "भारत", "expected": "भारत"},
{"input": "दिल्ली.", "expected": "दिल्ली"},
{"input": "शिक्षा?", "expected": "शिक्षा"},
// 19. Hungarian (hu) - beta
{"input": "Szia!", "expected": "szia"},
{"input": "Budapest", "expected": "budapest"},
{"input": "Magyar.", "expected": "magyar"},
{"input": "köszönöm", "expected": "koszonom"},
// 20. Indonesian (id) - beta
{"input": "Halo!", "expected": "halo"},
{"input": "Jakarta", "expected": "jakarta"},
{"input": "Indonesia.", "expected": "indonesia"},
{"input": "selamat pagi", "expected": "selamat pagi"},
// 21. Italian (it) - full
{"input": "Ciao!", "expected": "ciao"},
{"input": "Arrivederci", "expected": "arrivederci"},
{"input": "Roma.", "expected": "roma"},
{"input": "perché?", "expected": "perche"},
{"input": "È bellissimo!", "expected": "e bellissimo"},
// 22. Japanese (ja) - full
{"input": "こんにちは!", "expected": "こんにちは"},
{"input": "東京", "expected": "東京"},
{"input": "ありがとう。", "expected": "ありがとう"},
{"input": "さようなら?", "expected": "さようなら"},
// 23. Kannada (kn) - beta
{"input": "ನಮಸ್ತೆ!", "expected": "ನಮಸ್ತೆ"},
{"input": "ಬೆಂಗಳೂರು", "expected": "ಬೆಂಗಳೂರು"},
{"input": "ಕರ್ನಾಟಕ.", "expected": "ಕರ್ನಾಟಕ"},
// 24. Korean (ko) - full
{"input": "안녕하세요!", "expected": "안녕하세요"},
{"input": "서울", "expected": "서울"},
{"input": "한국어.", "expected": "한국어"},
{"input": "감사합니다?", "expected": "감사합니다"},
// 25. Lithuanian (lt) - beta
{"input": "Labas!", "expected": "labas"},
{"input": "Vilnius", "expected": "vilnius"},
{"input": "Lietuva.", "expected": "lietuva"},
{"input": "ačiū", "expected": "aciu"},
// 26. Latvian (lv) - beta
{"input": "Sveiki!", "expected": "sveiki"},
{"input": "Rīga", "expected": "riga"},
{"input": "Latvija.", "expected": "latvija"},
// 27. Malay (ms) - beta
{"input": "Selamat pagi!", "expected": "selamat pagi"},
{"input": "Kuala Lumpur", "expected": "kuala lumpur"},
{"input": "Malaysia.", "expected": "malaysia"},
// 28. Mongolian (mn) - beta
{"input": "Сайн байна уу!", "expected": "сайн байна уу"},
{"input": "Улаанбаатар", "expected": "улаанбаатар"},
{"input": "Монгол.", "expected": "монгол"},
// 29. Marathi (mr) - beta
{"input": "नमस्कार!", "expected": "नमस्कार"},
{"input": "मुंबई", "expected": "मुंबई"},
{"input": "महाराष्ट्र.", "expected": "महाराष्ट्र"},
// 30. Dutch (nl) - beta
{"input": "Hallo!", "expected": "hallo"},
{"input": "Amsterdam", "expected": "amsterdam"},
{"input": "Nederland.", "expected": "nederland"},
{"input": "dankjewel", "expected": "dankjewel"},
// 31. Punjabi (pa) - beta
{"input": "ਸਤਿ ਸ਼੍ਰੀ ਅਕਾਲ!", "expected": "ਸਤਿ ਸ਼੍ਰੀ ਅਕਾਲ"},
{"input": "ਪੰਜਾਬ", "expected": "ਪੰਜਾਬ"},
{"input": "ਅੰਮ੍ਰਿਤਸਰ.", "expected": "ਅੰਮ੍ਰਿਤਸਰ"},
// 32. Polish (pl) - beta
{"input": "Cześć!", "expected": "czesc"},
{"input": "Warszawa", "expected": "warszawa"},
{"input": "Polska.", "expected": "polska"},
{"input": "dziękuję", "expected": "dziekuje"},
// 33. Portuguese (pt) - full
{"input": "Olá!", "expected": "ola"},
{"input": "Obrigado", "expected": "obrigado"},
{"input": "São Paulo.", "expected": "sao paulo"},
{"input": "coração", "expected": "coracao"},
{"input": "não?", "expected": "nao"},
// 34. Romanian (ro) - beta
{"input": "Salut!", "expected": "salut"},
{"input": "București", "expected": "bucuresti"},
{"input": "România.", "expected": "romania"},
{"input": "mulțumesc", "expected": "multumesc"},
// 35. Russian (ru) - full
{"input": "Привет!", "expected": "привет"},
{"input": "Москва", "expected": "москва"},
{"input": "Россия.", "expected": "россия"},
{"input": "спасибо?", "expected": "спасибо"},
{"input": "магазин", "expected": "магазин"},
{"input": "магазин.", "expected": "магазин"},
// 36. Slovak (sk) - beta
{"input": "Ahoj!", "expected": "ahoj"},
{"input": "Bratislava", "expected": "bratislava"},
{"input": "Slovensko.", "expected": "slovensko"},
{"input": "ďakujem", "expected": "dakujem"},
// 37. Serbian (sr) - beta
{"input": "Здраво!", "expected": "здраво"},
{"input": "Београд", "expected": "београд"},
{"input": "Србија.", "expected": "србија"},
// 38. Ukrainian (uk) - beta
{"input": "Привіт!", "expected": "привіт"},
{"input": "Київ", "expected": "київ"},
{"input": "Україна.", "expected": "україна"},
// 39. Urdu (ur) - beta
{"input": "السلام علیکم!", "expected": "السلام علیکم"},
{"input": "کراچی", "expected": "کراچی"},
{"input": "پاکستان.", "expected": "پاکستان"},
// 40. Vietnamese (vi) - full
{"input": "Xin chào!", "expected": "xin chao"},
{"input": "Hà Nội", "expected": "ha noi"},
{"input": "Việt Nam.", "expected": "viet nam"},
{"input": "cảm ơn?", "expected": "cam on"},
// 41. Cantonese (yue) - beta
{"input": "你好!", "expected": "你好"},
{"input": "香港", "expected": "香港"},
{"input": "廣東話.", "expected": "廣東話"},
// 42. Chinese Simplified (zh-CN) - full
{"input": "你好!", "expected": "你好"},
{"input": "北京", "expected": "北京"},
{"input": "中国.", "expected": "中国"},
{"input": "谢谢?", "expected": "谢谢"},
// 43. Chinese Traditional (zh-TW) - full
{"input": "您好!", "expected": "您好"},
{"input": "台北", "expected": "台北"},
{"input": "台灣.", "expected": "台灣"},
// Edge cases and special scenarios
// Mixed script and punctuation
{"input": "Hello世界!", "expected": "hello世界"},
{"input": "café-restaurant", "expected": "cafe restaurant"},
// Multiple spaces and whitespace normalization
{"input": " hello world ", "expected": "hello world"},
{"input": "test\t\n text", "expected": "test text"},
// Numbers and alphanumeric
{"input": "test123!", "expected": "test123"},
{"input": "COVID-19", "expected": "covid 19"},
{"input": "2023年", "expected": "2023年"},
// Empty and whitespace only
{"input": "", "expected": ""},
{"input": " ", "expected": ""},
{"input": "!!!", "expected": ""},
// Special punctuation combinations
{"input": "What?!?", "expected": "what"},
{"input": "Well...", "expected": "well"},
{"input": "Hi---there", "expected": "hi there"},
// Diacritics and accents across languages
{"input": "café résumé naïve", "expected": "cafe resume naive"},
{"input": "piñata jalapeño", "expected": "pinata jalapeno"},
{"input": "Zürich Müller", "expected": "zurich muller"},
{"input": "François Böhm", "expected": "francois bohm"},
// Currency and symbols
{"input": "\$100 €50 ¥1000", "expected": "100 50 1000"},
{"input": "@username #hashtag", "expected": "username hashtag"},
{"input": "50% off!", "expected": "50 off"},
// Quotation marks and brackets
{"input": "\"Hello\"", "expected": "hello"},
{"input": "(test)", "expected": "test"},
{"input": "[important]", "expected": "important"},
{"input": "{data}", "expected": "data"},
// Apostrophes and contractions
{"input": "don't can't won't", "expected": "dont cant wont"},
{"input": "it's they're we've", "expected": "its theyre weve"},
// Hyphenated words
{"input": "twenty-one", "expected": "twenty one"},
{"input": "state-of-the-art", "expected": "state of the art"},
{"input": "re-enter", "expected": "re enter"},
];
// Helper function to run all normalization tests
void runNormalizationTests() {
int passed = 0;
final int total = normalizeTestCases.length;
for (int i = 0; i < normalizeTestCases.length; i++) {
final testCase = normalizeTestCases[i];
final input = testCase['input']!;
final expected = testCase['expected']!;
final actual = normalizeString(input, 'en'); // Default to English for tests
if (actual == expected) {
passed++;
Logs().i('✓ Test ${i + 1} PASSED: "$input" → "$actual"');
} else {
Logs().i(
'✗ Test ${i + 1} FAILED: "$input" → "$actual" (expected: "$expected")',
);
}
}
Logs().i(
'\nTest Results: $passed/$total tests passed (${(passed / total * 100).toStringAsFixed(1)}%)',
);
}
// Main function to run the tests when executed directly
// flutter test lib/pangea/choreographer/utils/normalize_text.dart
void main() {
group('Normalize String Tests', () {
for (int i = 0; i < normalizeTestCases.length; i++) {
final testCase = normalizeTestCases[i];
final input = testCase['input']!;
final expected = testCase['expected']!;
test('Test ${i + 1}: "$input" should normalize to "$expected"', () {
final actual =
normalizeString(input, 'en'); // Default to English for tests
expect(
actual,
equals(expected),
reason: 'Input: "$input" → Got: "$actual" → Expected: "$expected"',
);
});
}
});
}