From 90faab6068bb71925b9979af65be65801796b80e Mon Sep 17 00:00:00 2001 From: Wilson Date: Fri, 28 Feb 2025 13:18:36 -0500 Subject: [PATCH] fix(lemma_meaning_activity_generator): filter out empty strings as eligible distractors (#2004) * filter out empty strings as elible distractors * generated --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- lib/pangea/analytics_misc/level_display_name.dart | 4 ++-- .../toolbar/repo/lemma_meaning_activity_generator.dart | 7 +++++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/lib/pangea/analytics_misc/level_display_name.dart b/lib/pangea/analytics_misc/level_display_name.dart index 80296ffa2..98db46470 100644 --- a/lib/pangea/analytics_misc/level_display_name.dart +++ b/lib/pangea/analytics_misc/level_display_name.dart @@ -1,6 +1,6 @@ -import 'package:fluffychat/pangea/bot/utils/bot_name.dart'; import 'package:flutter/material.dart'; +import 'package:fluffychat/pangea/bot/utils/bot_name.dart'; import 'package:fluffychat/pangea/user/models/profile_model.dart'; import 'package:fluffychat/widgets/matrix.dart'; @@ -39,7 +39,7 @@ class LevelDisplayNameState extends State { @override Widget build(BuildContext context) { - if(widget.userId == BotName.byEnvironment){ + if (widget.userId == BotName.byEnvironment) { return const SizedBox(); } diff --git a/lib/pangea/toolbar/repo/lemma_meaning_activity_generator.dart b/lib/pangea/toolbar/repo/lemma_meaning_activity_generator.dart index 4dd18f57e..98afc9697 100644 --- a/lib/pangea/toolbar/repo/lemma_meaning_activity_generator.dart +++ b/lib/pangea/toolbar/repo/lemma_meaning_activity_generator.dart @@ -70,8 +70,11 @@ class LemmaMeaningActivityGenerator { .constructList(type: ConstructTypeEnum.vocab) .where( (c) => - c.lemma.toLowerCase() != lemma.toLowerCase() && - c.category.toLowerCase() == pos.toLowerCase(), + c.lemma.isNotEmpty && // must not be empty strings + c.lemma.toLowerCase() != + lemma.toLowerCase() && // must not be the lemma itself + c.category.toLowerCase() == + pos.toLowerCase(), // must be same part of speech ) .toList();