From b120f3ef847e76f53cc2a2e223250c0401029e7c Mon Sep 17 00:00:00 2001 From: ggurdin Date: Tue, 11 Nov 2025 14:15:17 -0500 Subject: [PATCH 1/2] fix: exclude 'not proper' noun type from construct analytics popups --- lib/pangea/analytics_misc/get_analytics_controller.dart | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/pangea/analytics_misc/get_analytics_controller.dart b/lib/pangea/analytics_misc/get_analytics_controller.dart index 78cda3b37..d07b78a8b 100644 --- a/lib/pangea/analytics_misc/get_analytics_controller.dart +++ b/lib/pangea/analytics_misc/get_analytics_controller.dart @@ -243,7 +243,14 @@ class GetAnalyticsController extends BaseController { } void _onUnlockMorphLemmas(Set unlocked) { - setState({'unlocked_constructs': unlocked}); + final Set excluded = { + ConstructIdentifier( + category: "NounType", + lemma: "Not_proper", + type: ConstructTypeEnum.morph, + ), + }; + setState({'unlocked_constructs': unlocked.difference(excluded)}); } /// A local cache of eventIds and construct uses for messages sent since the last update. From 92dfa52e47686f54bee44d5b52005806e74b6880 Mon Sep 17 00:00:00 2001 From: ggurdin Date: Tue, 11 Nov 2025 14:24:39 -0500 Subject: [PATCH 2/2] use lemma instead of construct ID for comparison --- .../analytics_misc/get_analytics_controller.dart | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/pangea/analytics_misc/get_analytics_controller.dart b/lib/pangea/analytics_misc/get_analytics_controller.dart index d07b78a8b..726826225 100644 --- a/lib/pangea/analytics_misc/get_analytics_controller.dart +++ b/lib/pangea/analytics_misc/get_analytics_controller.dart @@ -243,14 +243,14 @@ class GetAnalyticsController extends BaseController { } void _onUnlockMorphLemmas(Set unlocked) { - final Set excluded = { - ConstructIdentifier( - category: "NounType", - lemma: "Not_proper", - type: ConstructTypeEnum.morph, - ), + const excludedLemmas = {'not_proper'}; + + final filtered = { + for (final id in unlocked) + if (!excludedLemmas.contains(id.lemma.toLowerCase())) id, }; - setState({'unlocked_constructs': unlocked.difference(excluded)}); + + setState({'unlocked_constructs': filtered}); } /// A local cache of eventIds and construct uses for messages sent since the last update.