ember/fluffychat
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: add default names to course filters (#3845)

Browse source
This commit is contained in:
ggurdin 2025-09-02 15:59:36 -04:00 • committed by GitHub
parent cb3f4d191c
commit 72da5beeec
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 25 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/l10n/intl_en.arb
View file

@ -5264,5 +5264,6 @@
"waitNotDone": "Wait I’m not done!",
"waitingForOthersToFinish": "Waiting for the rest to finish up...",
"saveToCompletedActivities": "Save to completed activities",
"generatingSummary": "Analyzing chat and generating results"
"generatingSummary": "Analyzing chat and generating results",
"instructionsLanguage": "Instructions language"
}

20
lib/pangea/course_creation/course_plan_filter_widget.dart
View file

@ -9,7 +9,9 @@ class CoursePlanFilter<T> extends StatefulWidget {
final List<T> items;
final void Function(T?) onChanged;
final String Function(T?) displayname;
final String defaultName;
final String? shortName;
final String Function(T) displayname;
final bool enableSearch;
@ -21,10 +23,12 @@ class CoursePlanFilter<T> extends StatefulWidget {
required this.value,
required this.items,
required this.onChanged,
required this.defaultName,
required this.displayname,
required this.fontSize,
required this.iconSize,
this.enableSearch = false,
this.shortName,
});
@override
@ -59,7 +63,9 @@ class CoursePlanFilterState<T> extends State<CoursePlanFilter<T>> {
mainAxisSize: MainAxisSize.min,
children: [
Text(
widget.displayname(widget.value),
widget.value != null
? widget.displayname(widget.value as T)
: widget.defaultName,
style: TextStyle(
color: theme.colorScheme.onPrimary,
fontSize: widget.fontSize,
@ -79,7 +85,9 @@ class CoursePlanFilterState<T> extends State<CoursePlanFilter<T>> {
(item) => DropdownMenuItem(
value: item,
child: DropdownTextButton(
text: item == null ? "" : widget.displayname(item),
text: item != null
? widget.displayname(item)
: widget.shortName ?? widget.defaultName,
isSelected: item == widget.value,
),
),
@ -110,8 +118,10 @@ class CoursePlanFilterState<T> extends State<CoursePlanFilter<T>> {
),
),
searchMatchFn: (item, searchValue) {
final displayName =
widget.displayname(item.value).toLowerCase();
final displayName = (item.value != null
? widget.displayname(item.value as T)
: widget.defaultName)
.toLowerCase();
final search = searchValue.toLowerCase();
return displayName.startsWith(search);

14
lib/pangea/course_creation/new_course_view.dart
View file

@ -59,10 +59,10 @@ class NewCourseView extends StatelessWidget {
value: controller.languageLevelFilter,
onChanged: controller.setLanguageLevelFilter,
items: LanguageLevelTypeEnum.values,
displayname: (v) =>
v?.string ?? L10n.of(context).cefrLevelLabel,
displayname: (v) => v.string,
fontSize: descFontSize,
iconSize: iconSize,
defaultName: L10n.of(context).cefrLevelLabel,
),
CoursePlanFilter<LanguageModel>(
value: controller.instructionLanguageFilter,
@ -70,11 +70,13 @@ class NewCourseView extends StatelessWidget {
items: MatrixState
.pangeaController.pLanguageStore.baseOptions,
displayname: (v) =>
v?.getDisplayName(context) ??
L10n.of(context).languageOfInstructionsLabel,
v.getDisplayName(context) ?? v.displayName,
enableSearch: true,
fontSize: descFontSize,
iconSize: iconSize,
defaultName:
L10n.of(context).languageOfInstructionsLabel,
shortName: L10n.of(context).instructionsLanguage,
),
CoursePlanFilter<LanguageModel>(
value: controller.targetLanguageFilter,
@ -82,11 +84,11 @@ class NewCourseView extends StatelessWidget {
items: MatrixState
.pangeaController.pLanguageStore.targetOptions,
displayname: (v) =>
v?.getDisplayName(context) ??
L10n.of(context).targetLanguageLabel,
v.getDisplayName(context) ?? v.displayName,
enableSearch: true,
fontSize: descFontSize,
iconSize: iconSize,
defaultName: L10n.of(context).targetLanguageLabel,
),
],
),