ember/fluffychat
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: added fix to remove matches if they don't align with tokens and to use characters when replacing originalInput (#1948)

Browse source
This commit is contained in:
ggurdin 2025-02-26 15:51:09 -05:00 • committed by GitHub
parent 2a9f3a6e96
commit 6ddb18b6ec
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 37 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
lib/pangea/choreographer/controllers/igc_controller.dart
View file

@ -140,7 +140,38 @@ class IgcController {
filteredMatches.remove(match);
}
}
igcTextData!.matches = filteredMatches;
// If there are any matches that don't match up with token offsets,
// this indicates and choreographer bug. Remove them.
final tokens = igcTextData!.tokens;
final List<PangeaMatch> confirmedMatches = List.from(filteredMatches);
for (final match in filteredMatches) {
final substring = match.match.fullText.characters
.skip(match.match.offset)
.take(match.match.length);
final trimmed = substring.toString().trim().characters;
final matchOffset = (match.match.offset + match.match.length) -
(substring.length - trimmed.length);
final hasStartMatch = tokens.any(
(token) => token.text.offset == match.match.offset,
);
final hasEndMatch = tokens.any(
(token) => token.text.offset + token.text.length == matchOffset,
);
if (!hasStartMatch || !hasEndMatch) {
confirmedMatches.clear();
ErrorHandler.logError(
m: "Match offset and/or length do not tokens with matching offset and length. This is a choreographer bug.",
data: {
"match": match.toJson(),
"tokens": tokens.map((e) => e.toJson()).toList(),
},
);
break;
}
}
igcTextData!.matches = confirmedMatches;
// TODO - for each new match,
// check if existing igcTextData has one and only one match with the same error text and correction

10
lib/pangea/choreographer/models/igc_text_data_model.dart
View file

@ -175,11 +175,11 @@ class IGCTextData {
final SpanChoice replacement = pangeaMatch.match.choices![choiceIndex];
originalInput = originalInput.replaceRange(
pangeaMatch.match.offset,
pangeaMatch.match.offset + pangeaMatch.match.length,
replacement.value,
);
final newStart = originalInput.characters.take(pangeaMatch.match.offset);
final newEnd = originalInput.characters
.skip(pangeaMatch.match.offset + pangeaMatch.match.length);
final fullText = newStart + replacement.value.characters + newEnd;
originalInput = fullText.toString();
int startIndex;
int endIndex;