From e82438975b29264b7652e2d18ba2f510f33b3f88 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20Ku=C3=9Fowski?= Date: Mon, 23 Feb 2026 10:33:08 +0100 Subject: [PATCH] build: Check for commented code in CI --- .github/workflows/integrate.yaml | 13 ++++++++++--- lib/widgets/matrix.dart | 2 -- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/.github/workflows/integrate.yaml b/.github/workflows/integrate.yaml index 35d8d55f3..f600c2f37 100644 --- a/.github/workflows/integrate.yaml +++ b/.github/workflows/integrate.yaml @@ -25,13 +25,20 @@ jobs: - name: Check license compliance run: dart run license_checker check-licenses -c licenses.yaml --problematic - run: flutter analyze + - run: dart run dart_code_linter:metrics check-unused-code lib + - run: dart run dart_code_linter:metrics check-unused-files lib + - run: dart run dart_code_linter:metrics check-unused-l10n lib + - name: Check for commented-out Dart code with semicolons + run: | + if grep -R --include="*.dart" -nE '^[[:space:]]*//[^/<].*;[[:space:]]*$' lib/; then + echo "" + echo "❌ Found commented-out Dart code ending with semicolon." + exit 1 + fi - name: Add Firebase Messaging run: ./scripts/add-firebase-messaging.sh - run: flutter analyze - run: flutter test - - run: dart run dart_code_linter:metrics check-unused-code lib - - run: dart run dart_code_linter:metrics check-unused-files lib - - run: dart run dart_code_linter:metrics check-unused-l10n lib build_debug_apk: runs-on: ubuntu-latest diff --git a/lib/widgets/matrix.dart b/lib/widgets/matrix.dart index fb67822c4..3e3fa8ef9 100644 --- a/lib/widgets/matrix.dart +++ b/lib/widgets/matrix.dart @@ -32,8 +32,6 @@ import '../utils/account_bundles.dart'; import '../utils/background_push.dart'; import 'local_notifications_extension.dart'; -// import 'package:flutter_secure_storage/flutter_secure_storage.dart'; - class Matrix extends StatefulWidget { final Widget? child;