ember/fluffychat
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Prevent Grammar Practice Blank Fill-Ins (#5464)

Browse source
This commit is contained in:
ggurdin 2026-01-27 14:43:02 -05:00 • committed by GitHub
parent 165a8fb7a4
commit 61f18aa403
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 10 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
lib/pangea/analytics_practice/analytics_practice_session_repo.dart
View file

@ -1,5 +1,7 @@
import 'dart:math';
import 'package:flutter/material.dart';
import 'package:fluffychat/pangea/analytics_misc/construct_type_enum.dart';
import 'package:fluffychat/pangea/analytics_misc/construct_use_type_enum.dart';
import 'package:fluffychat/pangea/analytics_practice/analytics_practice_constants.dart';
@ -238,12 +240,19 @@ class AnalyticsPracticeSessionRepo {
for (int i = 0; i < choreo.choreoSteps.length; i++) {
final step = choreo.choreoSteps[i];
final igcMatch = step.acceptedOrIgnoredMatch;
final stepText = choreo.stepText(stepIndex: i - 1);
if (igcMatch?.isGrammarMatch != true ||
igcMatch?.match.bestChoice == null) {
continue;
}
final choices = igcMatch!.match.choices!.map((c) => c.value).toList();
if (igcMatch!.match.offset == 0 &&
igcMatch.match.length >= stepText.trim().characters.length) {
// Skip if the grammar error spans the entire step
continue;
}
final choices = igcMatch.match.choices!.map((c) => c.value).toList();
final choiceTokens = tokens
.where(
(token) =>

10
lib/pangea/events/event_wrappers/pangea_message_event.dart
View file

@ -593,7 +593,6 @@ class PangeaMessageEvent {
}
Future<String> requestRespresentationByL1() async {
debugPrint("LATEST EDIT: ${_latestEdit.toJson()}");
if (_l1Code == null || _l2Code == null) {
throw Exception("Missing language codes");
}
@ -605,9 +604,7 @@ class PangeaMessageEvent {
RepresentationEvent? rep;
if (!includedIT) {
// if the message didn't go through translation, get any l1 rep
debugPrint("REPRESENTATIONS: ${representations.length}");
rep = representationByLanguage(_l1Code!);
debugPrint("REP: $rep");
} else {
// if the message went through translation, get the non-original
// l1 rep since originalWritten could contain some l2 words
@ -624,13 +621,6 @@ class PangeaMessageEvent {
? (originalWritten?.langCode ?? _l1Code!)
: (originalSent?.langCode ?? _l2Code!);
debugPrint("Original written content: $originalWrittenContent");
debugPrint("Message display text: $messageDisplayText");
debugPrint("Original sent: ${originalSent?.content.toJson()}");
debugPrint(
"Message display rep: ${representationByLanguage(messageDisplayLangCode)?.content.toJson()}",
);
final resp = await _requestRepresentation(
includedIT ? originalWrittenContent : messageDisplayText,
_l1Code!,