ember/fluffychat
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: update activity session progress value on complete session, add cutoff times for recent practice uses to all target generators (#5889)

Browse source
This commit is contained in:
ggurdin 2026-03-04 11:46:37 -05:00 • committed by GitHub
parent d5ae87abf7
commit 1f5908721b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 31 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
lib/pangea/analytics_practice/analytics_practice_page.dart
View file

@ -239,6 +239,7 @@ class AnalyticsPracticeState extends State<AnalyticsPractice>
Future<void> _completeSession() async {
_sessionController.completeSession();
progress.value = _sessionController.progress;
setState(() {});
final bonus = _sessionController.bonusUses;

9
lib/pangea/analytics_practice/grammar_match_target_generator.dart
View file

@ -26,6 +26,7 @@ class GrammarMatchTargetGenerator {
final sortedConstructs = constructs.practiceSort(activityType);
final Set<String> seenForms = {};
final cutoffTime = DateTime.now().subtract(const Duration(hours: 24));
final morphInfoResult = await MorphsRepo.get(
MatrixState.pangeaController.userController.userL2,
@ -52,6 +53,14 @@ class GrammarMatchTargetGenerator {
continue;
}
final lastPracticeUse = construct.lastUseByTypes(
activityType.associatedUseTypes,
);
if (lastPracticeUse != null && lastPracticeUse.isAfter(cutoffTime)) {
continue;
}
List<InlineSpan>? exampleMessage;
final constructForms = construct.cappedUses
.where((u) => u.form != null)

10
lib/pangea/analytics_practice/vocab_audio_target_generator.dart
View file

@ -18,6 +18,8 @@ class VocabAudioTargetGenerator {
final Set<String> seenLemmas = {};
final Set<String> seenEventIds = {};
final cutoffTime = DateTime.now().subtract(const Duration(hours: 24));
final targets = <AnalyticsActivityTarget>[];
for (final construct in sortedConstructs) {
@ -27,6 +29,14 @@ class VocabAudioTargetGenerator {
if (seenLemmas.contains(construct.lemma)) continue;
final lastPracticeUse = construct.lastUseByTypes(
activityType.associatedUseTypes,
);
if (lastPracticeUse != null && lastPracticeUse.isAfter(cutoffTime)) {
continue;
}
// Try to get an audio example message with token data for this lemma
final exampleMessage = await ExampleMessageUtil.getAudioExampleMessage(
construct,

11
lib/pangea/analytics_practice/vocab_meaning_target_generator.dart
View file

@ -16,9 +16,20 @@ class VocabMeaningTargetGenerator {
final sortedConstructs = constructs.practiceSort(activityType);
final Set<String> seenLemmas = {};
final cutoffTime = DateTime.now().subtract(const Duration(hours: 24));
final targets = <AnalyticsActivityTarget>[];
for (final construct in sortedConstructs) {
if (seenLemmas.contains(construct.lemma)) continue;
final lastPracticeUse = construct.lastUseByTypes(
activityType.associatedUseTypes,
);
if (lastPracticeUse != null && lastPracticeUse.isAfter(cutoffTime)) {
continue;
}
seenLemmas.add(construct.lemma);
if (!construct.cappedUses.any(