From 1f47aecb13b01c8cb7092b072d4e6e93ee670a07 Mon Sep 17 00:00:00 2001 From: Ava Shilling <165050625+avashilling@users.noreply.github.com> Date: Thu, 29 Jan 2026 14:13:14 -0500 Subject: [PATCH] fix: return capped uses allows all grammar error targets to be searched for recent uses and filtered out, even maxed out ones --- lib/pangea/analytics_data/analytics_data_service.dart | 4 +++- .../analytics_practice/analytics_practice_session_repo.dart | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/pangea/analytics_data/analytics_data_service.dart b/lib/pangea/analytics_data/analytics_data_service.dart index b339c8638..1cfe805be 100644 --- a/lib/pangea/analytics_data/analytics_data_service.dart +++ b/lib/pangea/analytics_data/analytics_data_service.dart @@ -241,6 +241,7 @@ class AnalyticsDataService { String? roomId, DateTime? since, ConstructUseTypeEnum? type, + bool filterCapped = true, }) async { await _ensureInitialized(); final uses = await _analyticsClientGetter.database.getUses( @@ -263,7 +264,8 @@ class AnalyticsDataService { cappedLastUseCache[use.identifier] = constructs.cappedLastUse; } final cappedLastUse = cappedLastUseCache[use.identifier]; - if (cappedLastUse != null && use.timeStamp.isAfter(cappedLastUse)) { + if (filterCapped && + (cappedLastUse != null && use.timeStamp.isAfter(cappedLastUse))) { continue; } filtered.add(use); diff --git a/lib/pangea/analytics_practice/analytics_practice_session_repo.dart b/lib/pangea/analytics_practice/analytics_practice_session_repo.dart index 65c9cd7e0..9c430bcb0 100644 --- a/lib/pangea/analytics_practice/analytics_practice_session_repo.dart +++ b/lib/pangea/analytics_practice/analytics_practice_session_repo.dart @@ -318,7 +318,7 @@ class AnalyticsPracticeSessionRepo { final recentUses = await MatrixState .pangeaController.matrixState.analyticsDataService - .getUses(since: cutoffTime); + .getUses(since: cutoffTime, filterCapped: false); final hasRecentPractice = recentUses.any( (use) =>