From 0583409b098338e8b7b017b1eee63f225da4cf4a Mon Sep 17 00:00:00 2001 From: ggurdin <46800240+ggurdin@users.noreply.github.com> Date: Tue, 27 Jan 2026 16:50:34 -0500 Subject: [PATCH] fix: don't include error span as choice in grammar error practice if the translation contains the error span (#5474) --- .../analytics_practice/grammar_error_practice_generator.dart | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/pangea/analytics_practice/grammar_error_practice_generator.dart b/lib/pangea/analytics_practice/grammar_error_practice_generator.dart index 854d1b66a..9284a3c9f 100644 --- a/lib/pangea/analytics_practice/grammar_error_practice_generator.dart +++ b/lib/pangea/analytics_practice/grammar_error_practice_generator.dart @@ -31,7 +31,10 @@ class GrammarErrorPracticeGenerator { .take(igcMatch.length) .toString(); - choices.add(errorSpan); + if (!req.grammarErrorInfo!.translation.contains(errorSpan)) { + choices.add(errorSpan); + } + choices.shuffle(); return MessageActivityResponse( activity: GrammarErrorPracticeActivityModel(